[parachain-template] pallet configurations into mod configs
#3809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asiniscalchi
changed the title
mod configs
asiniscalchi
changed the title
mod configsmod configs
asiniscalchi
changed the title
mod configsmod configs
bkchr
approved these changes
Mar 26, 2024
|
The CI pipeline was cancelled due to failure one of the required jobs. |
ggwpez
approved these changes
Mar 28, 2024
|
@kianenigma ping :) |
kianenigma
reviewed
Mar 31, 2024
| /// [`ParaChainDefaultConfig`](`struct@frame_system::config_preludes::ParaChainDefaultConfig`), | ||
| /// but overridden as needed. | ||
| #[derive_impl(frame_system::config_preludes::ParaChainDefaultConfig)] | ||
| impl frame_system::Config for Runtime { |
There was a problem hiding this comment.
Are all the ones that are mentioned here actually overwriting something? type Hash, type BlockWeight etc should be the same in ParachainDefaultConfig
kianenigma
approved these changes
Mar 31, 2024
There was a problem hiding this comment.
This is a good step, but if interested, I would suggest you to:
- provide sensible defaults for
SolochainandParachainfor:balances,system,timestamp,transaction-payment,sudo. - Update all 3 templates to use these defaults.
- @gupnik can provide supervision.
Merged
via the queue into
paritytech:master
with commit Apr 1, 2024
8d30534
127 of 132 checks passed
pgherveou
pushed a commit
that referenced
this pull request
Apr 2, 2024
This PR introduces a refactor of the parachain runtime configuration by consolidating all pallet configurations into a new module named `configs`. This change aims to improve the readability and maintainability of the runtime configuration by centralizing all configuration parameters. ## Changes - **Creation of `configs.rs`**: A new file `configs.rs` has been added under `templates/parachain/runtime/src/`, containing all the runtime configurations previously scattered across `lib.rs`. - **Refactoring of `lib.rs`**: The `lib.rs` file has been significantly slimmed down by removing the inline pallet configurations and importing them from `configs.rs` instead. - **Optimization of Import Statements**: Reorganized import statements to clarify the runtime's dependency structure. ### Benefits - **Improved Readability**: With configurations being centralized, developers can now easily locate and review runtime parameters without navigating through the `lib.rs` file. This refactor does not introduce any changes to the runtime logic but improves the project structure for better development experience. --------- Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Ank4n
pushed a commit
that referenced
this pull request
Apr 9, 2024
This PR introduces a refactor of the parachain runtime configuration by consolidating all pallet configurations into a new module named `configs`. This change aims to improve the readability and maintainability of the runtime configuration by centralizing all configuration parameters. ## Changes - **Creation of `configs.rs`**: A new file `configs.rs` has been added under `templates/parachain/runtime/src/`, containing all the runtime configurations previously scattered across `lib.rs`. - **Refactoring of `lib.rs`**: The `lib.rs` file has been significantly slimmed down by removing the inline pallet configurations and importing them from `configs.rs` instead. - **Optimization of Import Statements**: Reorganized import statements to clarify the runtime's dependency structure. ### Benefits - **Improved Readability**: With configurations being centralized, developers can now easily locate and review runtime parameters without navigating through the `lib.rs` file. This refactor does not introduce any changes to the runtime logic but improves the project structure for better development experience. --------- Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
dharjeezy
pushed a commit
to dharjeezy/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
…tech#3809) This PR introduces a refactor of the parachain runtime configuration by consolidating all pallet configurations into a new module named `configs`. This change aims to improve the readability and maintainability of the runtime configuration by centralizing all configuration parameters. ## Changes - **Creation of `configs.rs`**: A new file `configs.rs` has been added under `templates/parachain/runtime/src/`, containing all the runtime configurations previously scattered across `lib.rs`. - **Refactoring of `lib.rs`**: The `lib.rs` file has been significantly slimmed down by removing the inline pallet configurations and importing them from `configs.rs` instead. - **Optimization of Import Statements**: Reorganized import statements to clarify the runtime's dependency structure. ### Benefits - **Improved Readability**: With configurations being centralized, developers can now easily locate and review runtime parameters without navigating through the `lib.rs` file. This refactor does not introduce any changes to the runtime logic but improves the project structure for better development experience. --------- Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a refactor of the parachain runtime configuration by consolidating all pallet configurations into a new module named
configs. This change aims to improve the readability and maintainability of the runtime configuration by centralizing all configuration parameters.Changes
configs.rs: A new fileconfigs.rshas been added undertemplates/parachain/runtime/src/, containing all the runtime configurations previously scattered acrosslib.rs.lib.rs: Thelib.rsfile has been significantly slimmed down by removing the inline pallet configurations and importing them fromconfigs.rsinstead.Benefits
lib.rsfile.This refactor does not introduce any changes to the runtime logic but improves the project structure for better development experience.